gc namespace for k8sspark k8sflink #3392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3392 +/- ##
==========================================
+ Coverage 18.00% 18.02% +0.02%
==========================================
Files 1403 1403
Lines 145380 145392 +12
==========================================
+ Hits 26171 26212 +41
+ Misses 116512 116480 -32
- Partials 2697 2700 +3
|
|
|
chengjoey
force-pushed
the
feature/k8sspark-flink-gc-namespace
branch
from
0c0d676 to
4c429a6
Compare
sfwn
requested changes
Dec 16, 2021
modules/pipeline/conf/conf.go
Outdated
| @@ -112,6 +112,9 @@ type Conf struct { | |||
| // scheduler executor refresh interval | |||
| ExecutorRefreshIntervalMinute uint64 `env:"EXECUTOR_REFRESH_INTERVAL_MINUTE" default:"20"` | |||
| SpecifyImagePullPolicy string `env:"SPECIFY_IMAGE_PULL_POLICY" default:"IfNotPresent"` | |||
|
|
|||
| // k8s namespace | |||
| EnableSpecifiedK8SNamespace string `env:"ENABLE_SPECIFIED_K8S_NAMESPACE"` | |||
There was a problem hiding this comment.
I think specified_k8s_namespace should be a request level config.
There was a problem hiding this comment.
adjusted, only use task.Extra.NotPipelineControlledNs
NotPipelineControlledNs is request level config
modules/pipeline/conf/conf.go
Outdated
| @@ -112,6 +112,9 @@ type Conf struct { | |||
| // scheduler executor refresh interval | |||
| ExecutorRefreshIntervalMinute uint64 `env:"EXECUTOR_REFRESH_INTERVAL_MINUTE" default:"20"` | |||
| SpecifyImagePullPolicy string `env:"SPECIFY_IMAGE_PULL_POLICY" default:"IfNotPresent"` | |||
|
|
|||
| // k8s namespace | |||
| EnableSpecifiedK8SNamespace string `env:"ENABLE_SPECIFIED_K8S_NAMESPACE"` | |||
|
|
||
| // delete namespace after gc flinkcluster | ||
| namespace := task.Extra.Namespace | ||
| if conf.EnableSpecifiedK8SNamespace() == "" && !task.Extra.NotPipelineControlledNs { |
chengjoey
force-pushed
the
feature/k8sspark-flink-gc-namespace
branch
from
4c429a6 to
d1d562c
Compare
sfwn
approved these changes
Dec 17, 2021
|
/approve |
erda-bot
approved these changes
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
Add one of the following kinds:
/kind feature
What this PR does / why we need it:
gc namespace for k8sspark k8sflink
Which issue(s) this PR fixes:
Specified Reviewers:
/assign @your-reviewer
ChangeLog
Need cherry-pick to release versions?
Add comment like
/cherry-pick release/1.0when this PR is merged.