Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: issue manage only show table #3394

Merged
merged 5 commits into from
Dec 17, 2021

Conversation

sfwn
Copy link
Member

@sfwn sfwn commented Dec 16, 2021

What type of this PR

/kind feature

What this PR does / why we need it:

feature: issue manage only show table, remove useless kanban/gantt/viewGroup.
details:

  • remove state binding in protocol yaml; remove default_rendering
  • issuePagingRequest use globalState

Which issue(s) this PR fixes:

Specified Reviewers:

/assign @Effet

@sfwn sfwn added the feature label Dec 16, 2021
@erda-bot erda-bot requested a review from Effet December 16, 2021 09:44
@sfwn sfwn added the dop devops plaoform label Dec 16, 2021
@sfwn sfwn marked this pull request as draft December 16, 2021 09:45
@sfwn sfwn force-pushed the feature/issue-manage-remove-kanban branch from d3463d2 to 3a67fd8 Compare December 17, 2021 09:12
@sfwn sfwn marked this pull request as ready for review December 17, 2021 09:15
@codecov
Copy link

codecov bot commented Dec 17, 2021

Codecov Report

Merging #3394 (100a0f0) into master (f098a6e) will increase coverage by 0.16%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3394      +/-   ##
==========================================
+ Coverage   18.01%   18.17%   +0.16%     
==========================================
  Files        1403     1398       -5     
  Lines      145389   143974    -1415     
==========================================
- Hits        26188    26174      -14     
+ Misses     116482   115074    -1408     
- Partials     2719     2726       +7     
Impacted Files Coverage Δ
...components/issue-manage/issueFilter/init_filter.go 0.00% <0.00%> (ø)
...tocol/components/issue-manage/issueFilter/model.go 77.14% <ø> (+4.76%) ⬆️
...ocol/components/issue-manage/issueFilter/render.go 12.42% <0.00%> (-0.08%) ⬇️
...tocol/components/issue-manage/issueFilter/state.go 0.00% <ø> (ø)
...tocol/components/issue-manage/issueTable/render.go 43.07% <0.00%> (+7.26%) ⬆️

@Effet Effet merged commit e3df8f5 into erda-project:master Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dop devops plaoform feature
Development

Successfully merging this pull request may close these issues.

2 participants