Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allows podInfo.Cluster to be empty #3398

Merged
merged 2 commits into from
Dec 17, 2021
Merged

fix: allows podInfo.Cluster to be empty #3398

merged 2 commits into from
Dec 17, 2021

Conversation

dspo
Copy link
Contributor

@dspo dspo commented Dec 17, 2021

What type of this PR

Add one of the following kinds:
/kind bugfix

What this PR does / why we need it:

Fixed the problem of inaccurate project resource request value

Which issue(s) this PR fixes:

  • Fixes #your-issue_number
  • [Erda Cloud Issue Link](paste your link here)

Specified Reviewers:

/assign @your-reviewer

ChangeLog

Language Changelog
🇺🇸 English
🇨🇳 中文

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@dspo dspo requested a review from luobily December 17, 2021 02:56
@dspo dspo added the bugfix label Dec 17, 2021
@codecov
Copy link

codecov bot commented Dec 17, 2021

Codecov Report

Merging #3398 (d812135) into master (153fb4b) will not change coverage.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3398   +/-   ##
=======================================
  Coverage   18.00%   18.00%           
=======================================
  Files        1403     1403           
  Lines      145392   145392           
=======================================
  Hits        26175    26175           
  Misses     116525   116525           
  Partials     2692     2692           
Impacted Files Coverage Δ
modules/core-services/services/project/project.go 15.77% <0.00%> (ø)
modules/core-services/services/project/cache.go 69.23% <100.00%> (ø)

@dspo dspo changed the title fix: allows podInfo.Cluster is empty fix: allows podInfo.Cluster to be empty Dec 17, 2021
@luobily
Copy link
Member

luobily commented Dec 17, 2021

/approve

@erda-bot erda-bot merged commit da58d7f into erda-project:master Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants