check data version when accept from executor done chan #3402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3402 +/- ##
=======================================
Coverage 18.14% 18.14%
=======================================
Files 1411 1411
Lines 144748 144764 +16
=======================================
+ Hits 26263 26273 +10
- Misses 115857 115862 +5
- Partials 2628 2629 +1
|
chengjoey
force-pushed
the
fix/pipeline-loop-task-outputs
branch
from
16f30ef to
78b332e
Compare
|
tested in terminus-test |
sfwn
requested changes
Dec 21, 2021
| Version string | ||
| } | ||
|
|
||
| func (pt *PipelineTask) GenerateExecutorVersion() string { |
There was a problem hiding this comment.
What is executor version? No, executor doesn't have version.
You should use GenerateExecutorDoneChanDataVersion.
| return fmt.Sprintf("%s-%d-loop-%d", CtxExecutorChVersionPrefix, pt.ID, pt.Extra.LoopOptions.LoopedTimes) | ||
| } | ||
|
|
||
| func (pt *PipelineTask) CheckExecutorVersion(actualVersion string) error { |
chengjoey
force-pushed
the
fix/pipeline-loop-task-outputs
branch
from
78b332e to
19d4d07
Compare
sfwn
requested changes
Dec 21, 2021
| @@ -67,11 +67,12 @@ func (d *define) Create(ctx context.Context, task *spec.PipelineTask) (interface | |||
| func (d *define) Start(ctx context.Context, task *spec.PipelineTask) (interface{}, error) { | |||
|
|
|||
| go func(ctx context.Context, task *spec.PipelineTask) { | |||
| executorVersion := task.GenerateExecutorDoneChanDataVersion() | |||
| @@ -278,6 +279,26 @@ func (pt *PipelineTask) GetMetadata() apistructs.Metadata { | |||
| return pt.Result.Metadata | |||
| } | |||
|
|
|||
| type ExecutorChanData struct { | |||
chengjoey
force-pushed
the
fix/pipeline-loop-task-outputs
branch
from
19d4d07 to
94f2bbf
Compare
sfwn
approved these changes
Dec 21, 2021
|
/approve |
erda-bot
approved these changes
Dec 21, 2021
|
/cherry-pick release/1.5 |
erda-bot
pushed a commit
to erda-bot/erda
that referenced
this pull request
Dec 21, 2021
Effet
pushed a commit
that referenced
this pull request
Dec 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
Add one of the following kinds:
/kind bugfix
What this PR does / why we need it:
check data version when accept from executor done chan
Which issue(s) this PR fixes:
Specified Reviewers:
/assign @your-reviewer
ChangeLog
Need cherry-pick to release versions?
Add comment like
/cherry-pick release/1.0when this PR is merged.