Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pkg storage: for detect storageclass name #3427

Merged
merged 1 commit into from
Dec 21, 2021

Conversation

wangzhuzhen
Copy link
Contributor

What type of this PR

Add one of the following kinds:
/kind feature

What this PR does / why we need it:

/ for pipeline ECI Pod enabled, need detect storageclass base diskType and cloud provider

Which issue(s) this PR fixes:

  • Fixes #your-issue_number
  • [Erda Cloud Issue Link](paste your link here)

Specified Reviewers:

/assign @iutx

ChangeLog

add pkg/k8s/storage
add constant and struct info in apistructs

Language Changelog
🇺🇸 English
🇨🇳 中文

@erda-bot erda-bot requested a review from iutx December 21, 2021 03:22
iutx
iutx previously approved these changes Dec 21, 2021
Copy link
Member

@iutx iutx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #3427 (2960151) into master (cadfc85) will decrease coverage by 0.00%.
The diff coverage is 96.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3427      +/-   ##
==========================================
- Coverage   18.14%   18.13%   -0.01%     
==========================================
  Files        1410     1411       +1     
  Lines      144725   144744      +19     
==========================================
- Hits        26261    26256       -5     
- Misses     115819   115862      +43     
+ Partials     2645     2626      -19     
Impacted Files Coverage Δ
pkg/k8s/storage/detect_sc.go 96.29% <96.29%> (ø)
modules/dop/services/issue/issue.go 4.21% <0.00%> (-2.72%) ⬇️
pkg/parser/pipelineyml/visitor_ref_op.go 46.23% <0.00%> (-0.54%) ⬇️
modules/monitor/apm/topology/topology.go 27.54% <0.00%> (-0.19%) ⬇️
modules/gittar/pkg/gitmodule/repo.go 0.00% <0.00%> (ø)
modules/msp/apm/service/apm.service.service.go 66.08% <0.00%> (+1.86%) ⬆️

Copy link
Contributor

@sixther-dc sixther-dc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@sixther-dc sixther-dc merged commit 6a7e437 into erda-project:master Dec 21, 2021
@iutx
Copy link
Member

iutx commented Dec 24, 2021

/cherry-pick release/1.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants