Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If it is a MAC system, skip the global configuration internationalizttion information #3429

Merged
merged 1 commit into from
Dec 21, 2021

Conversation

kakj-go
Copy link
Contributor

@kakj-go kakj-go commented Dec 21, 2021

What type of this PR

/kind bugfix

What this PR does / why we need it:

The MAC system does not support obtaining the current collaboration process, which will lead to panic

Which issue(s) this PR fixes:

ChangeLog

Language Changelog
🇺🇸 English The i18n global setting header no longer supports the mac system, because the underlying library for getting the coroutine does not support
🇨🇳 中文 i18n 全局设置 header 忽略 Mac 系统,因为底层获取协程的库不支持

@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #3429 (8a124c4) into master (cadfc85) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3429   +/-   ##
=======================================
  Coverage   18.14%   18.14%           
=======================================
  Files        1410     1410           
  Lines      144725   144721    -4     
=======================================
+ Hits        26261    26266    +5     
  Misses     115819   115819           
+ Partials     2645     2636    -9     
Impacted Files Coverage Δ
pkg/i18n/helper.go 42.85% <0.00%> (-7.15%) ⬇️
pkg/parser/pipelineyml/visitor_ref_op.go 46.23% <0.00%> (-0.54%) ⬇️
modules/monitor/apm/topology/topology.go 27.54% <0.00%> (-0.19%) ⬇️
modules/gittar/pkg/gitmodule/repo.go 0.00% <0.00%> (ø)
modules/dop/services/issue/issue.go 7.59% <0.00%> (+0.65%) ⬆️
modules/msp/apm/service/apm.service.service.go 66.08% <0.00%> (+1.86%) ⬆️

@sfwn sfwn added the bugfix label Dec 21, 2021
@sfwn
Copy link
Member

sfwn commented Dec 21, 2021

/approve

@erda-bot erda-bot merged commit 53400d2 into erda-project:master Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants