Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #3419: check if an addon that is not a platform exists when the project is deleted #3450

Merged

Conversation

erda-bot
Copy link
Member

Cherry pick of #3419 on release/1.5.

Squashed commit message:

commit 1bdba36b6adc8224be56b69ef64ac30da8342659
Author: littlejian <17816869670@163.com>
Date:   Wed Dec 22 11:40:48 2021 +0800

    check if an addon that is not a platform exists when the project is deleted (#3419)
    
    * check if an addon that is not a platform exists
    
    * add comment

What type of this PR

Add one of the following kinds:
/kind polish

What this PR does / why we need it:

check if an addon that is not a platform exists when the project is deleted

Which issue(s) this PR fixes:

Specified Reviewers:

/assign @Effet

ChangeLog

Language Changelog
🇺🇸 English
🇨🇳 中文

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

…eleted (erda-project#3419)

* check if an addon that is not a platform exists

* add comment
@codecov
Copy link

codecov bot commented Dec 22, 2021

Codecov Report

Merging #3450 (1bdba36) into release/1.5 (99c4b0a) will increase coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release/1.5    #3450      +/-   ##
===============================================
+ Coverage        18.18%   18.19%   +0.01%     
===============================================
  Files             1411     1411              
  Lines           144995   145010      +15     
===============================================
+ Hits             26362    26389      +27     
+ Misses          115967   115933      -34     
- Partials          2666     2688      +22     
Impacted Files Coverage Δ
modules/core-services/services/project/project.go 17.80% <66.66%> (+2.03%) ⬆️

@Effet Effet merged commit 02d039f into erda-project:release/1.5 Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants