Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Standard issue filter provider, add issue complexity and states #3469

Merged
merged 1 commit into from
Jan 4, 2022

Conversation

shuofan
Copy link
Contributor

@shuofan shuofan commented Dec 23, 2021

What type of this PR

feature refactor

What this PR does / why we need it:

Standard issue filter provider, add issue complexity and states

Which issue(s) this PR fixes:

Specified Reviewers:

/assign @sfwn

ChangeLog

Language Changelog
🇺🇸 English standrad issue filter
🇨🇳 中文 事项筛选器

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@erda-bot erda-bot requested a review from sfwn December 23, 2021 02:09
@shuofan shuofan added dop devops plaoform feature refactor labels Dec 23, 2021
@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #3469 (33333d1) into master (4b70b6a) will decrease coverage by 0.03%.
The diff coverage is 3.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3469      +/-   ##
==========================================
- Coverage   18.40%   18.37%   -0.04%     
==========================================
  Files        1437     1437              
  Lines      149001   149075      +74     
==========================================
- Hits        27425    27392      -33     
- Misses     118759   118914     +155     
+ Partials     2817     2769      -48     
Impacted Files Coverage Δ
...tocol/components/issue-manage/issueFilter/model.go 8.55% <0.00%> (-0.58%) ⬇️
...tocol/components/issue-manage/issueFilter/state.go 0.00% <0.00%> (ø)
...api/component-protocol/components/base/provider.go 0.00% <0.00%> (ø)
...iders/component-protocol/issueFilter/conditions.go 0.00% <0.00%> (ø)
...viders/component-protocol/issueFilter/filterset.go 9.30% <ø> (ø)
...viders/component-protocol/issueFilter/in_params.go 0.00% <ø> (ø)
...roviders/component-protocol/issueFilter/options.go 0.00% <0.00%> (ø)
...oviders/component-protocol/issueFilter/provider.go 2.17% <3.12%> (ø)
...api/component-protocol/components/base/register.go 70.83% <100.00%> (+4.16%) ⬆️
.../dop/services/issuestream/issue_stream_template.go 60.97% <0.00%> (-2.44%) ⬇️
... and 5 more

@shuofan shuofan marked this pull request as draft December 23, 2021 03:28
@shuofan shuofan force-pushed the feature/issue-manage-filter branch from 6307350 to 8b92d7c Compare December 31, 2021 08:10
@shuofan shuofan changed the title Standard issue filter provider, add issue complexity and states feat: Standard issue filter provider, add issue complexity and states Dec 31, 2021
@shuofan shuofan marked this pull request as ready for review December 31, 2021 08:14
InitProviderWithNameSpace(MakeComponentProviderName(scenario, compName), creator)
}

func InitProviderWithNameSpace(providerName string, creator servicehub.Creator) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not expose this method, rename to initProviderWithCustomName.
Add a new methods InitProviderToDefaultNamespace for default comp register.

}

func init() {
base.InitProviderWithCreator("issue-kanban", "issueFilter", func() servicehub.Provider {
base.InitProviderWithNameSpace("component-protocol.default-components.issueFilter", func() servicehub.Provider {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use InitProviderToDefaultNamespace

@@ -33,6 +34,13 @@ func MustGetScenarioAndCompNameFromProviderKey(providerKey string) (scenario, co
}

func GetScenarioAndCompNameFromProviderKey(providerKey string) (scenario, compName, instanceName string, err error) {
if strings.HasPrefix(providerKey, defaultComponentProviderNamePrefix) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add ut for this.

@shuofan shuofan force-pushed the feature/issue-manage-filter branch from 8b92d7c to d22583c Compare December 31, 2021 11:21
@shuofan shuofan force-pushed the feature/issue-manage-filter branch from d22583c to 33333d1 Compare December 31, 2021 11:25
@sfwn
Copy link
Member

sfwn commented Jan 4, 2022

/approve

@erda-bot erda-bot merged commit d72406f into erda-project:master Jan 4, 2022
@sfwn sfwn deleted the feature/issue-manage-filter branch January 4, 2022 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants