Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: App list item selectable, goto operation, icon update #3974

Merged
merged 2 commits into from
Jan 26, 2022

Conversation

shuofan
Copy link
Contributor

@shuofan shuofan commented Jan 26, 2022

What this PR does / why we need it:

App list icon selectable, operation, icon update

Which issue(s) this PR fixes:

Specified Reviewers:

/assign @sfwn

ChangeLog

Language Changelog
🇺🇸 English App list icon selectable, operation, icon update
🇨🇳 中文 应用列表 更新

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@erda-bot erda-bot requested a review from sfwn January 26, 2022 09:33
@shuofan shuofan changed the title feat: App list icon selectable, operation, icon update feat: App list item selectable, goto operation, icon update Jan 26, 2022
@codecov
Copy link

codecov bot commented Jan 26, 2022

Codecov Report

Merging #3974 (1d75ead) into master (5a4ecb0) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3974      +/-   ##
==========================================
- Coverage   19.17%   19.12%   -0.05%     
==========================================
  Files        1477     1481       +4     
  Lines      154491   154871     +380     
==========================================
+ Hits        29616    29626      +10     
- Misses     121903   122271     +368     
- Partials     2972     2974       +2     
Impacted Files Coverage Δ
...tocol/components/issue-manage/issueTable/render.go 37.40% <100.00%> (+0.12%) ⬆️
...les/openapi/api/apis/uc/uc_user_update_userinfo.go 0.00% <0.00%> (ø)
modules/openapi/server.go 0.00% <0.00%> (ø)
modules/openapi/loginserver.go 0.00% <0.00%> (ø)
modules/openapi/reverseproxy.go 4.72% <0.00%> (ø)
modules/openapi/provider.go 21.42% <0.00%> (ø)

if item.IsPublic {
isPublic = "publicApp"
publicIcon = "gongyou"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...

@sfwn
Copy link
Member

sfwn commented Jan 26, 2022

/approve

@erda-bot erda-bot merged commit 8c2e691 into erda-project:master Jan 26, 2022
@sfwn sfwn deleted the feature/app-list-all branch January 26, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants