Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set option: returnAllComponents true value #4038

Merged

Conversation

chengjoey
Copy link
Contributor

What this PR does / why we need it:

set option: returnAllComponents true value

Which issue(s) this PR fixes:

Specified Reviewers:

/assign @your-reviewer

ChangeLog

Language Changelog
🇺🇸 English Fix the bug that set option: returnAllComponents true value
🇨🇳 中文 修复了自动化测试组件化渲染

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@sfwn
Copy link
Member

sfwn commented Feb 14, 2022

/approve

@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #4038 (746e7ee) into master (66a947e) will decrease coverage by 0.05%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4038      +/-   ##
==========================================
- Coverage   19.15%   19.09%   -0.06%     
==========================================
  Files        1476     1482       +6     
  Lines      155440   156268     +828     
==========================================
+ Hits        29768    29838      +70     
- Misses     122658   123407     +749     
- Partials     3014     3023       +9     
Impacted Files Coverage Δ
...t-protocol/components/project-runtime/list/list.go 36.42% <90.00%> (+4.19%) ⬆️
modules/dop/services/apidocsvc/funcs.go 5.63% <0.00%> (ø)
modules/dop/services/apidocsvc/api_docs.go 0.00% <0.00%> (ø)
modules/dop/services/apidocsvc/filetree.go 0.00% <0.00%> (ø)
modules/dop/services/apidocsvc/ws_handler.go 0.00% <0.00%> (ø)
modules/dop/services/apidocsvc/ws_upgrade.go 0.00% <0.00%> (ø)
modules/dop/services/apidocsvc/svc.go 77.27% <0.00%> (ø)
modules/dop/initialize.go 4.45% <0.00%> (+0.13%) ⬆️
modules/dop/services/assetsvc/funcs.go 27.58% <0.00%> (+27.58%) ⬆️
... and 1 more

@erda-bot erda-bot merged commit c234d7f into erda-project:master Feb 14, 2022
@chengjoey chengjoey deleted the fix/issue-record-component-yml branch April 18, 2022 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants