Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use proto-go #4117

Merged

Conversation

CraigMChen
Copy link
Contributor

What this PR does / why we need it:

refactor: use proto in release manage

Which issue(s) this PR fixes:

  • Fixes #your-issue_number
  • [Erda Cloud Issue Link](paste your link here)

Specified Reviewers:

/assign @luobily

ChangeLog

Language Changelog
🇺🇸 English refactor: use proto in release manage
🇨🇳 中文 重构:在制品管理中使用proto,删除原有endpoints

Cherry-pick

Need cherry-pick to release/1.6-alpha.4

@erda-bot erda-bot requested a review from luobily February 22, 2022 06:19
@CraigMChen CraigMChen force-pushed the polish/refactor-release-proto branch from 032cdc7 to 1eb236b Compare February 22, 2022 06:39
@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #4117 (afb65ed) into master (c0bb4cb) will decrease coverage by 0.05%.
The diff coverage is 20.61%.

❗ Current head afb65ed differs from pull request most recent head d695449. Consider uploading reports for the commit d695449 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4117      +/-   ##
==========================================
- Coverage   18.83%   18.78%   -0.06%     
==========================================
  Files        1484     1486       +2     
  Lines      157369   158499    +1130     
==========================================
+ Hits        29648    29776     +128     
- Misses     124595   125570     +975     
- Partials     3126     3153      +27     
Impacted Files Coverage Δ
apistructs/release.go 38.82% <ø> (ø)
modules/dicehub/endpoints/endpoints.go 29.88% <0.00%> (+4.64%) ⬆️
modules/dicehub/endpoints/release.go 14.22% <0.00%> (+0.07%) ⬆️
modules/dicehub/release/audit.go 0.00% <0.00%> (ø)
modules/dicehub/release/provider.go 3.37% <0.00%> (-5.46%) ⬇️
...odules/dicehub/release/release.get.dice.service.go 0.00% <0.00%> (ø)
...l/components/release-manage/releaseTable/render.go 24.55% <0.00%> (-0.58%) ⬇️
modules/orchestrator/endpoints/deployment.go 0.00% <0.00%> (ø)
modules/orchestrator/endpoints/deployment_order.go 0.00% <0.00%> (ø)
modules/orchestrator/endpoints/endpoints.go 0.00% <0.00%> (ø)
... and 57 more

@CraigMChen CraigMChen force-pushed the polish/refactor-release-proto branch 4 times, most recently from 2cae741 to ed66a81 Compare February 22, 2022 09:19
@CraigMChen CraigMChen force-pushed the polish/refactor-release-proto branch from ed66a81 to d695449 Compare February 22, 2022 09:46
Copy link
Contributor

@sixther-dc sixther-dc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@sixther-dc sixther-dc merged commit e48f304 into erda-project:master Feb 22, 2022
@sixther-dc
Copy link
Contributor

/cherry-pick release/1.6-alpha.4

erda-bot pushed a commit to erda-bot/erda that referenced this pull request Feb 22, 2022
sixther-dc pushed a commit that referenced this pull request Feb 22, 2022
Co-authored-by: CMC <49681321+CraigMChen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants