Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bad mysql addon password decryption #4193

Merged

Conversation

Effet
Copy link
Member

@Effet Effet commented Mar 1, 2022

What this PR does / why we need it:

bad mysql addon password decryption

Which issue(s) this PR fixes:

  • Fixes #your-issue_number
  • [Erda Cloud Issue Link](paste your link here)

Specified Reviewers:

/assign @your-reviewer

ChangeLog

Language Changelog
🇺🇸 English bad mysql addon password decryption
🇨🇳 中文 修复历史数据 mysql addon 密码解密失败

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@erda-bot erda-bot added the bugfix label Mar 1, 2022
@sfwn
Copy link
Member

sfwn commented Mar 1, 2022

/approve

@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #4193 (17ad88f) into master (2e8d057) will decrease coverage by 0.03%.
The diff coverage is 17.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4193      +/-   ##
==========================================
- Coverage   19.20%   19.17%   -0.04%     
==========================================
  Files        1495     1501       +6     
  Lines      159069   159498     +429     
==========================================
+ Hits        30551    30582      +31     
- Misses     125336   125712     +376     
- Partials     3182     3204      +22     
Impacted Files Coverage Δ
...es/orchestrator/components/addon/mysql/provider.go 30.95% <0.00%> (+4.48%) ⬆️
...chestrator/components/addon/mysql/mysql.service.go 24.84% <26.66%> (+1.07%) ⬆️
modules/gittar/helper/git_protocol.go 0.00% <0.00%> (ø)
modules/gittar/helper/packet_line.go 0.00% <0.00%> (ø)
modules/gittar/helper/git_cmd.go 3.06% <0.00%> (ø)
modules/gittar/helper/git_send_odb.go 0.00% <0.00%> (ø)
modules/gittar/helper/header_cache.go 0.00% <0.00%> (ø)
modules/gittar/helper/git_hooks.go 0.00% <0.00%> (ø)
...ator/services/deployment_order/deployment_order.go 37.77% <0.00%> (+11.11%) ⬆️
... and 2 more

@erda-bot erda-bot merged commit 5adcf4f into erda-project:master Mar 1, 2022
@Effet Effet deleted the hotfix/bad-mysql-password-decrypt branch March 1, 2022 05:51
@Effet
Copy link
Member Author

Effet commented Mar 1, 2022

/cherry-pick release/2.0

erda-bot pushed a commit to erda-bot/erda that referenced this pull request Mar 1, 2022
Effet added a commit that referenced this pull request Mar 1, 2022
Co-authored-by: Effet <nesuadark@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants