Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add vms target in customize alert rule #4223

Merged
merged 2 commits into from
Mar 2, 2022

Conversation

Counterflowwind
Copy link
Contributor

What this PR does / why we need it:

add vms target in customize alert rule

ChangeLog

Language Changelog
🇺🇸 English add vms target in customize alert rule
🇨🇳 中文 增加电话告警通知方式

@erda-bot erda-bot added the bugfix label Mar 2, 2022
@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #4223 (0b5f051) into master (60ff17f) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4223   +/-   ##
=======================================
  Coverage   19.17%   19.17%           
=======================================
  Files        1509     1509           
  Lines      160897   160917   +20     
=======================================
+ Hits        30844    30863   +19     
+ Misses     126823   126802   -21     
- Partials     3230     3252   +22     
Impacted Files Coverage Δ
.../core/monitor/alert/alert-apis/adapt/expression.go 34.43% <ø> (ø)
modules/orchestrator/endpoints/deployment_order.go 0.00% <0.00%> (ø)
...rvices/deployment_order/deployment_order_create.go 42.98% <0.00%> (+3.67%) ⬆️

@snakorse
Copy link
Contributor

snakorse commented Mar 2, 2022

/approve

@erda-bot erda-bot merged commit e4802a8 into erda-project:master Mar 2, 2022
@Counterflowwind
Copy link
Contributor Author

/cherry-pick release/2.0

1 similar comment
@Counterflowwind
Copy link
Contributor Author

/cherry-pick release/2.0

erda-bot pushed a commit to erda-bot/erda that referenced this pull request Mar 3, 2022
erda-bot added a commit that referenced this pull request Mar 3, 2022
Co-authored-by: panjiayao <44628544+Counterflowwind@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants