Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: get same mutex lock for registercenter and configcenter #6429

Merged
merged 2 commits into from
Sep 14, 2024

Conversation

CeerDecy
Copy link
Member

@CeerDecy CeerDecy commented Aug 30, 2024

What this PR does / why we need it:

get same mutex lock for registercenter and configcenter

Which issue(s) this PR fixes:

Specified Reviewers:

/assign @iutx

ChangeLog

Language Changelog
🇺🇸 English get same mutex lock for registercenter and configcenter
🇨🇳 中文 注册中心和配置中心获取同一把锁,避免它俩同时部署

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@erda-bot erda-bot requested a review from iutx August 30, 2024 09:38
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 15.60%. Comparing base (c315ced) to head (9066061).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
...pps/msp/resource/deploy/coordinator/coordinator.go 0.00% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6429      +/-   ##
==========================================
+ Coverage   15.54%   15.60%   +0.05%     
==========================================
  Files        3682     3674       -8     
  Lines      312196   311530     -666     
==========================================
+ Hits        48545    48628      +83     
+ Misses     258197   257448     -749     
  Partials     5454     5454              
Flag Coverage Δ
by-github-actions 15.60% <0.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...pps/msp/resource/deploy/coordinator/coordinator.go 3.48% <0.00%> (-0.11%) ⬇️

... and 18 files with indirect coverage changes

Copy link
Member

@iutx iutx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @sfwn

ResourceRegisterCenter = "registercenter"
ResourceConfigCenter = "config-center"

RegisterAndConfigMutexKey = "ConfigLoveRegister"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

romantic

@sfwn
Copy link
Member

sfwn commented Sep 14, 2024

/approve

@sfwn sfwn merged commit ac09b4f into erda-project:master Sep 14, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants