Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refreshBasicInfo skip if empty #6457

Closed

Conversation

iutx
Copy link
Member

@iutx iutx commented Oct 22, 2024

What this PR does / why we need it:

refreshBasicInfo skip if empty

will cause error

ERRO[2024-10-22 11:18:42.567] failed to get all user joined projects, err: Error 1055 (42000): Expression #1 of SELECT list is not in GROUP BY clause and contains nonaggregated column 'erda.member.id' which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by  module=efficiency-measure
ERRO[2024-10-22 11:18:42.567] failed to refresh basic user projects, err: Error 1055 (42000): Expression #1 of SELECT list is not in GROUP BY clause and contains nonaggregated column 'erda.member.id' which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by  module=efficiency-measure

(/go/src/github.com/erda-project/erda/internal/core/legacy/dao/member.go:493) 
[2024-10-22 11:18:42]  Error 1055 (42000): Expression #1 of SELECT list is not in GROUP BY clause and contains nonaggregated column 'erda.member.id' which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by 

Which issue(s) this PR fixes:

  • Fixes #your-issue_number
  • [Erda Cloud Issue Link](paste your link here)

Specified Reviewers:

/assign @sfwn

ChangeLog

Language Changelog
🇺🇸 English refreshBasicInfo skip if empty
🇨🇳 中文 refreshBasicInfo 跳过空的场景,避免 sql 执行

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

Signed-off-by: Ash <root@viper.run>
@erda-bot erda-bot requested a review from sfwn October 22, 2024 10:05
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 15.14%. Comparing base (7cd710a) to head (ab88972).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
...pps/dop/providers/efficiency_measure/basic_info.go 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6457   +/-   ##
=======================================
  Coverage   15.14%   15.14%           
=======================================
  Files        3674     3674           
  Lines      376848   376851    +3     
=======================================
+ Hits        57081    57085    +4     
+ Misses     314308   314305    -3     
- Partials     5459     5461    +2     
Flag Coverage Δ
by-github-actions 15.14% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...pps/dop/providers/efficiency_measure/basic_info.go 0.00% <0.00%> (ø)

... and 7 files with indirect coverage changes

Copy link

stale bot commented Nov 13, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 13, 2024
@iutx iutx removed the wontfix label Nov 15, 2024
Copy link

stale bot commented Dec 7, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Dec 7, 2024
@stale stale bot closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant