Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmp): node details render EOF #6462

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

iutx
Copy link
Member

@iutx iutx commented Oct 29, 2024

What this PR does / why we need it:

Fix node details render EOF.
Remove github.com/rancher/wrangler dependence.

image

Which issue(s) this PR fixes:

Specified Reviewers:

/assign @sfwn

ChangeLog

Language Changelog
🇺🇸 English fix cmp node details render EOF
🇨🇳 中文 修复 CMP 节点信息渲染 EOF

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@erda-bot erda-bot added bugfix cmp cloud management platform manag labels Oct 29, 2024
@erda-bot erda-bot requested a review from sfwn October 29, 2024 08:32
@iutx iutx force-pushed the fix/cmp-render-eof branch 2 times, most recently from 81c8405 to f6a76f9 Compare October 29, 2024 08:36
Signed-off-by: Ash <root@viper.run>
@iutx iutx force-pushed the fix/cmp-render-eof branch from f6a76f9 to b54681a Compare October 29, 2024 08:37
@sfwn
Copy link
Member

sfwn commented Oct 29, 2024

/approve

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.15%. Comparing base (9aaa584) to head (b54681a).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6462   +/-   ##
=======================================
  Coverage   15.14%   15.15%           
=======================================
  Files        3674     3674           
  Lines      376844   376844           
=======================================
+ Hits        57076    57105   +29     
+ Misses     314307   314274   -33     
- Partials     5461     5465    +4     
Flag Coverage Δ
by-github-actions 15.15% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

@erda-bot erda-bot merged commit 8dc57ee into erda-project:master Oct 29, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved bugfix cmp cloud management platform manag
Development

Successfully merging this pull request may close these issues.

3 participants