Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: cmp support new import method #806

Merged
merged 2 commits into from
Jul 8, 2021

Conversation

iutx
Copy link
Member

@iutx iutx commented Jul 8, 2021

What type of this PR

Add one of the following kinds:
/kind feature

What this PR does / why we need it:

cmp: support new import method

Which issue(s) this PR fixes:

  • Fixes #your-issue_number
  • [Erda Cloud Issue Link](paste your link here)

Specified Reviewers:

/assign @luobily

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@iutx iutx added cmp cloud management platform manag feature labels Jul 8, 2021
@iutx iutx force-pushed the feature/cmp-cluster-import branch 9 times, most recently from 2458089 to c6208a4 Compare July 8, 2021 06:46
@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

Merging #806 (4638c86) into master (ee9ae96) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #806   +/-   ##
=======================================
  Coverage   10.07%   10.07%           
=======================================
  Files         944      944           
  Lines       89192    89192           
=======================================
  Hits         8983     8983           
  Misses      79273    79273           
  Partials      936      936           
Impacted Files Coverage Δ
apistructs/cmp.go 0.00% <ø> (ø)
apistructs/cmp_cloud_resource.go 0.00% <ø> (ø)
apistructs/org.go 0.00% <ø> (ø)

modules/cmp/endpoints/cluster.go Outdated Show resolved Hide resolved
modules/cmp/endpoints/cluster.go Outdated Show resolved Hide resolved
modules/cmp/impl/clusters/proxy-deploy.go Show resolved Hide resolved
@iutx iutx force-pushed the feature/cmp-cluster-import branch 11 times, most recently from c7eb66a to 7d28847 Compare July 8, 2021 11:47
@luobily
Copy link
Member

luobily commented Jul 8, 2021

/approve

erda-bot
erda-bot previously approved these changes Jul 8, 2021
@iutx iutx force-pushed the feature/cmp-cluster-import branch from c46dcdb to ea27629 Compare July 8, 2021 12:01
@luobily
Copy link
Member

luobily commented Jul 8, 2021

/approve

@erda-bot erda-bot merged commit d480709 into erda-project:master Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cmp cloud management platform manag feature
Development

Successfully merging this pull request may close these issues.

3 participants