You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Look at use of sub_path as argument to status_url, and the fact that the code currently has to “tell” view controllers what their path is, which seems odd.
Fix trailing (/) in URL regular expressions.
Make sure the current code isn't changing querysets into plain lists, and/or address problems arising from that if it is doing so.
Use the tmpdir fixtures from py.test—current code leaves tempfiles all over the repo root directory. (Note that these are likely the uploaded Django temporary files, but still, a better answer to this would be good.)
The text was updated successfully, but these errors were encountered:
This issue is for the comments CM made in #301 that aren't big enough to warrant having individual issues for them.
build_eregs_args
returns clearer in its docstring.if
/else
early-exit branching cleaner/clearer in FileUploadView.six.moves.urllib.parse.urlparse
instead of thetry
/except
approach I'm using at the moment.safe
string methods (orsix
equivalents?) for handling hashed file contents instead of thetry
/except
I'm currently using.utils.get_host
._fake_redis_job
to returningnamedtuple("FakeRedisJob", ['id'])(fake_pipeline_id)
instead of its currenttype
?I addressed the above in #308.
sub_path
as argument tostatus_url
, and the fact that the code currently has to “tell” view controllers what their path is, which seems odd.(/)
in URL regular expressions.queryset
s into plainlist
s, and/or address problems arising from that if it is doing so.tmpdir
fixtures frompy.test
—current code leaves tempfiles all over the repo root directory. (Note that these are likely the uploaded Django temporary files, but still, a better answer to this would be good.)The text was updated successfully, but these errors were encountered: