Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Add support for dynamic notice & comment homepage #398

Merged
merged 3 commits into from
Jun 8, 2016

Conversation

tadhg-ohiggins
Copy link
Contributor

No description provided.

@tadhg-ohiggins
Copy link
Contributor Author

Supports 18F/epa-notice#365


from __future__ import unicode_literals

from operator import itemgetter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very neat!

@cmc333333
Copy link
Member

Two small suggestions above, @tadhg-ohiggins:

  • Using TemplateView
  • standardizing enum comparisons in templates

If you don't have time to address, we can circle back later; lmk

@cmc333333
Copy link
Member

Made an issue for the enums: #400; let's not worry about TemplateView

@cmc333333 cmc333333 merged commit 095a30a into eregs:master Jun 8, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants