Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor base_types to use dispatch (WIP) #34

Merged
merged 5 commits into from
Mar 2, 2024

Conversation

erezsh
Copy link
Owner

@erezsh erezsh commented Jul 25, 2023

(Initial refactor using Dispatch inside base_types.py)

Copy link

@prplex prplex bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. Posted 4 comments.

runtype/base_types.py Show resolved Hide resolved
runtype/base_types.py Show resolved Hide resolved
runtype/base_types.py Outdated Show resolved Hide resolved
runtype/base_types.py Outdated Show resolved Hide resolved
@erezsh erezsh changed the title Test PR Refactor base_types to use dispatch (WIP) Jul 25, 2023
Higher priority functions will be chosen in case of ambiguous dispatch.
Most specific functions will still be selected first, even if they have
a lower priority than a less specific function.
@erezsh erezsh force-pushed the base_types_using_dispatch branch from 1b36579 to 0c0fc61 Compare March 2, 2024 14:10
@erezsh erezsh merged commit 452fa1e into master Mar 2, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant