Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for tuple[x, ...]; Fix for comparing generic types; support for types.UnionType #36

Merged
merged 3 commits into from
Aug 16, 2023

Conversation

erezsh
Copy link
Owner

@erezsh erezsh commented Aug 15, 2023

No description provided.

Copy link

@prplex prplex bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. Posted 2 comments.

tests/test_basic.py Show resolved Hide resolved
tests/test_basic.py Show resolved Hide resolved
@erezsh erezsh merged commit 22f5ea0 into master Aug 16, 2023
14 checks passed
@KokeCacao
Copy link

KokeCacao commented Oct 6, 2023

Looks like

print(issubclass(float, typing.Tuple[float, float]))

will still produce an error TypeError: '<=' not supported between instances of '_Float' and 'ProductType'.

Any intention to implement the fix?

erezsh added a commit that referenced this pull request Oct 6, 2023
erezsh added a commit that referenced this pull request Oct 6, 2023
Fix following PR #36 (reported by @KokeCacao)
@erezsh
Copy link
Owner Author

erezsh commented Oct 6, 2023

@KokeCacao Yeah, thanks for letting me know. I just merged a fix to master in PR #44.

I'm also working on a PR that would reduce the chances of things like that slipping through the cracks, but it's low priority for me, so I can't say when it will be ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants