Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added multidispatch singleton decorator, and multidispatch_final #42

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Conversation

erezsh
Copy link
Owner

@erezsh erezsh commented Sep 22, 2023

No description provided.

Copy link

@prplex prplex bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. Posted 1 comment.

@@ -54,3 +56,64 @@ def Dispatch(typesystem: TypeSystem = PythonTyping()):
return MultiDispatch(typesystem)



typesystem: TypeSystem = PythonTyping()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider avoiding global mutable state. It's typically better to encapsulate it within classes or use it at a function scope.

@erezsh erezsh merged commit 68917e8 into master Sep 22, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant