Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix following PR #36 (reported by @KokeCacao) #44

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Fix following PR #36 (reported by @KokeCacao) #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions runtype/base_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,12 @@ def __le__(self, other):

return NotImplemented

def __ge__(self, other):
if isinstance(other, DataType):
return False

return NotImplemented


class ContainerType(DataType):
"""Base class for containers, such as generics.
Expand Down
1 change: 1 addition & 0 deletions tests/test_basic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ def test_basic(self):

assert isa((3,), (Tuple[int], list))
assert not isa([40, 2], Tuple[int, int])
assert not issubclass(float, typing.Tuple[float, float])
erezsh marked this conversation as resolved.
Show resolved Hide resolved

# Mappings
assert issubclass(dict, abc.Mapping)
Expand Down
Loading