Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WHOX is not sanitized for ::1 #1980

Closed
slingamn opened this issue Jul 15, 2022 · 1 comment
Closed

WHOX is not sanitized for ::1 #1980

slingamn opened this issue Jul 15, 2022 · 1 comment
Labels
Milestone

Comments

@slingamn
Copy link
Member

Reported by knolle in the support channel:

whois shivaramtest
@time=2022-07-15T01:47:17.992Z :irc.ergo.chat 311 shivaramtest shivaramtest ~u s7fnmzgihcy5g.irc * r
@time=2022-07-15T01:47:17.992Z :irc.ergo.chat 319 shivaramtest shivaramtest :#chat #test
@time=2022-07-15T01:47:17.992Z :irc.ergo.chat 338 shivaramtest shivaramtest ~u@0::1 0::1 :Actual user@host, Actual IP
@time=2022-07-15T01:47:17.992Z :irc.ergo.chat 379 shivaramtest shivaramtest :is using modes +Zi
@time=2022-07-15T01:47:17.992Z :irc.ergo.chat 671 shivaramtest shivaramtest :is using a secure connection
@time=2022-07-15T01:47:17.992Z :irc.ergo.chat 317 shivaramtest shivaramtest 43 1657849594 :seconds idle, signon time
@time=2022-07-15T01:47:17.992Z :irc.ergo.chat 318 shivaramtest shivaramtest :End of /WHOIS list
who #test
@time=2022-07-15T01:48:53.120Z :irc.ergo.chat 352 shivaramtest #test ~u pwaukivzzi8mk.irc irc.ergo.chat petteri Hr :0 Petteri
@time=2022-07-15T01:48:53.120Z :irc.ergo.chat 352 shivaramtest #test ~u s7fnmzgihcy5g.irc irc.ergo.chat shivaramtest H :0 r
@time=2022-07-15T01:48:53.120Z :irc.ergo.chat 352 shivaramtest #test ~u s57bjfdt23bwk.irc irc.ergo.chat y Hr :0 y
@time=2022-07-15T01:48:53.120Z :irc.ergo.chat 315 shivaramtest #test :End of WHO list
who #test %ai
@time=2022-07-15T01:49:03.712Z :irc.ergo.chat 354 shivaramtest 255.255.255.255 petteri
:irc.ergo.chat 400 * :Error assembling message for sending
@time=2022-07-15T01:49:03.712Z :irc.ergo.chat 354 shivaramtest 255.255.255.255 y
@time=2022-07-15T01:49:03.712Z :irc.ergo.chat 315 shivaramtest #test :End of WHO list

::1 is not valid as a non-final parameter, hence the 400. This must be represented instead as 0::1, as in the WHO output.

@slingamn slingamn added the bug label Jul 15, 2022
@slingamn slingamn added this to the v2.11 milestone Jul 15, 2022
@slingamn
Copy link
Member Author

859d0cd

slingamn added a commit that referenced this issue Jul 15, 2022
slingamn added a commit that referenced this issue Jun 14, 2023
Sanitize ::1 to 0::1 in WHOX output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant