Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Real name length not checked #2123

Closed
eskimo opened this issue Feb 8, 2024 · 5 comments
Closed

Real name length not checked #2123

eskimo opened this issue Feb 8, 2024 · 5 comments

Comments

@eskimo
Copy link

eskimo commented Feb 8, 2024

Seems like real name isn't checked for length, making you able to end up with names like this. Definitely not ideal.

[11:09:49] butts has userhost ~0@w3beg2gmmqdvw.igloo and real name "ha hiopsdgio hjgds hjoidgsh iogds hiodgs hoidsg hiodgs hiodgsj iophdsgj piodgs hjpiodgs hiodgs hoidsg hoidsg hoisdhoidsghiodsg hiodsg hiosihosd ohidsg hiodgs hiodgs hoiadghio adgohidgs hoidsg hiosdg hio hiogdsh iodsgh iobds hiods hiosdgh iodbsh iosbdh oibdxh iodxb hoidbxshio dsg hiodsg hiodsg hiodsgioh dgsh iodsg hiodgs hiodsg hiodsgohi dgs hiodgs hiodsg hiodsghio ds hiobds hiodbxsohi bdsh iobdh oidsvbho ibdxs hoidsb hiodsb jidbsj iohbds jhiopbds"

@slingamn
Copy link
Member

slingamn commented Feb 8, 2024

Good candidate for adding to the limits block:

ergo/default.yaml

Lines 815 to 821 in d97e964

# limits - these need to be the same across the network
limits:
# nicklen is the max nick length allowed
nicklen: 32
# identlen is the max ident length allowed
identlen: 20

@slingamn
Copy link
Member

slingamn commented Feb 8, 2024

Anyone have thoughts on a recommended default? Maybe 200-300 chars

@eskimo
Copy link
Author

eskimo commented Feb 8, 2024

I honestly think 100 is more than enough.

@slingamn
Copy link
Member

slingamn commented Feb 8, 2024

Libera does 50 (!?), Inspircd testnet does 130

@eskimo
Copy link
Author

eskimo commented Feb 8, 2024

Yeah I think 100-120 is pretty fair, leaves enough room for 99% of people to fit their name and email which is common. 50 is probably too low.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants