add --init to suggested docker run invocations #2097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See ergochat#2096; this should fix unreaped zombies when using an auth-script or ip-check-script that spawns its own subprocesses, then exits before reaping them.
|
Yeah, this seems like a sensible fix for poorly behaved subprocesses :) Might be worth adding a small note about why it's needed in the docs? It's a little esoteric and not entirely obvious why ergo would need it at first glance. |
slingamn
added a commit
to slingamn/ergo
that referenced
this pull request
Nov 15, 2023
Follows up from ergochat#2096, ergochat#2097
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tagging @csmith as our resident Docker expert :-p
It seems like this fixes #2096 ( unreaped zombies when using an auth-script or ip-check-script that spawns its own subprocesses, then exits before reaping them), and has basically no downside. Thoughts?