Gracefully handle NS cert add myself <fp> #2128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A non-operator with the nick "mynick" attempts to register a fingerprint to their authenticated account. They /msg NickServ cert add mynick <fingerprint> NickServ responds with "Insufficient privileges" because they've accidentally invoked the operator syntax (to action other accounts). This patch allows the user to add the fingerprint if the client's account is identical to the target account. Signed-off-by: Matt Hamilton <m@tthamilton.com>
|
oh, heh, I think this resolves #2098 |
Compare the case-normalized target to Account()
|
Thanks very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A non-operator with the nick "mynick" attempts to register a fingerprint to their authenticated account.
/msg NickServ cert add mynick <fingerprint>NickServ responds with "Insufficient privileges" because they've accidentally invoked the operator syntax (to action other accounts).
This patch allows the user to add the fingerprint if the client's account is identical to the target account.
--
Note about implementation, this does add an extra mutex lock and unlock by calling
client.Account()vs modifying the conditional logic below, but as this is security sensitive and an infrequent operation, I took the easy route of setting the zero value ontarget.