[6.0] GetVar(inputIndex, varId) for reading context variable from another input and fix for Context.getVar #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kushti
changed the title
kushti
changed the title
aslesarenko
requested changes
Oct 20, 2024
| /** | ||
| * A variant of `getVar` to extract a context variable by id and type from any input | ||
| * | ||
| * @param inputId - input index |
There was a problem hiding this comment.
If it is index, then better call it inputIndex
| } else { | ||
| an[Exception] should be thrownBy(varTest()) | ||
| } | ||
| } |
There was a problem hiding this comment.
Missing test case for different actual and expected types.
There was a problem hiding this comment.
Reworked into more nuanced check (for sigma.validation.ValidationException now)
| reg1 -> UnitConstant.instance | ||
| )) | ||
| ) | ||
| } |
There was a problem hiding this comment.
how is this test related to the PR ? Also, why to ask others about tests introduced by you (starting from 4f2579bbaeec )3def75d42629d7821073f39804b2 )
|
@aslesarenko comments addressed , please make another pass |
aslesarenko
approved these changes
Oct 21, 2024
Co-authored-by: Alexander Slesarenko <aslesarenko@users.noreply.github.com>
Co-authored-by: Alexander Slesarenko <aslesarenko@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
fix for CONTEXT.getVar failing deserialization and compilation ( close Context.getVar failing compilation (and likely can't be deserialized) #978 )
CONTEXT.getVarFromInput method to read context variable from any input.
Note, that the new method is intentionally not throwing an exception on expected vs real types. This can be used to have
getVaralternative without an exception, as in: