Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possible race condition in PrecompiledScriptReducer #793

Merged
merged 4 commits into from
May 4, 2022

Conversation

aslesarenko
Copy link
Member

Closes #778

In this PR:

  • mutable access to IR is protected by ReentrantLock
  • improved assertion reporting

@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #793 (60c5e7b) into master (44253ac) will decrease coverage by 0.09%.
The diff coverage is 40.62%.

@@            Coverage Diff             @@
##           master     #793      +/-   ##
==========================================
- Coverage   66.53%   66.43%   -0.10%     
==========================================
  Files         245      245              
  Lines       18542    18566      +24     
  Branches      613      602      -11     
==========================================
- Hits        12337    12335       -2     
- Misses       6205     6231      +26     
Impacted Files Coverage Δ
...state/interpreter/PrecompiledScriptProcessor.scala 98.11% <ø> (ø)
core/src/main/scala/scalan/Base.scala 71.26% <29.62%> (-5.16%) ⬇️
...ate/src/main/scala/sigmastate/eval/IRContext.scala 89.47% <100.00%> (-0.27%) ⬇️
...tate/src/main/scala/sigmastate/utils/Helpers.scala 54.41% <100.00%> (+2.10%) ⬆️
.../src/main/scala/special/collection/ViewColls.scala 87.91% <0.00%> (-1.10%) ⬇️
...ain/scala/special/collection/CollsOverArrays.scala 86.48% <0.00%> (-0.61%) ⬇️
...c/main/scala/special/sigma/impl/SigmaDslImpl.scala 46.38% <0.00%> (-0.23%) ⬇️
...cala/sigmastate/serialization/TypeSerializer.scala 96.55% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44253ac...60c5e7b. Read the comment docs.

@aslesarenko aslesarenko requested a review from kushti April 20, 2022 18:40
@aslesarenko aslesarenko added the S-ready-for-review Status: This PR is ready for review label Apr 20, 2022
@aslesarenko aslesarenko merged commit 727b7b7 into master May 4, 2022
@aslesarenko aslesarenko deleted the fix-i778 branch May 11, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-ready-for-review Status: This PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants