-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First working demo of random price generation #10
Conversation
I will review this very soon. It is on my track. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TL;DR:
- random_sd() can return a negative value (which is invalid)
- Formatting (indentation, namespace std::, comments)
Most comments from cpp are migrated here to the header.
… namespace sts. Note the comments are migrated to the header.
Note that you can start writing the README.md for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good. I don't mind there is no one empty line between two functions to separate them. LGTM! 🚀
The code should work with distinct outputs each time a function is called.
All these code are based on std: mt19937 (https://cplusplus.com/reference/random/mt19937/) and std::normal_distribution (https://en.cppreference.com/w/cpp/numeric/random/normal_distribution)