Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile: fix target all msvc with specified OUTPUT #142

Merged
merged 1 commit into from
Jun 16, 2024
Merged

Makefile: fix target all msvc with specified OUTPUT #142

merged 1 commit into from
Jun 16, 2024

Conversation

eric15342335
Copy link
Owner

  • Fix a bug where make all OUTPUT=some-custom-name will fail
    • same for make msvc OUTPUT=some-custom-name

@eric15342335 eric15342335 added bug Something isn't working Comp: compilation Related to compilation of the program. E.g. Makefile, CI/CD, compiler errors, platform portability labels Jun 16, 2024
@eric15342335 eric15342335 self-assigned this Jun 16, 2024
@eric15342335 eric15342335 merged commit bac788f into main Jun 16, 2024
31 of 33 checks passed
@eric15342335 eric15342335 deleted the output branch June 16, 2024 11:32
@eric15342335
Copy link
Owner Author

Very unlucky coverage drop.
No need to care this. I have adjusted the error threshold in respond to this.

eric15342335 added a commit that referenced this pull request Jun 18, 2024
@eric15342335
Coverall Integration (#140)
7bf8647 
Test case coverage

Improve CI dependency graph (#141)

Makefile: fix target all msvc with specified OUTPUT (#142)

* Fix a bug where `make all OUTPUT=some-custom-name` will fail
  * same for `make msvc OUTPUT=some-custom-name`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Prismatiscence Prismatiscence Awaiting requested review from Prismatiscence

@comet13579 comet13579 Awaiting requested review from comet13579

@MaxChungsh MaxChungsh Awaiting requested review from MaxChungsh

@84ds84d8s 84ds84d8s Awaiting requested review from 84ds84d8s

Assignees

@eric15342335 eric15342335

Labels
bug Something isn't working Comp: compilation Related to compilation of the program. E.g. Makefile, CI/CD, compiler errors, platform portability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eric15342335