Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding typing, changing the data model, probably a v3.0 rewrite #91

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

ericdill
Copy link
Owner

@ericdill ericdill commented Mar 5, 2023

For now I'm exploring what it would look like to add typing and pydantic data models to depfinder. It's turning into somwhat of a rewrite of the whole library. We'll see how it goes. If anything, this would be a major version bump to 3.0 if / when we decide to merge this

@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2023

Codecov Report

Patch coverage: 93.27% and project coverage change: +0.80 🎉

Comparison is base (e981839) 91.73% compared to head (e6c083e) 92.54%.

❗ Current head e6c083e differs from pull request most recent head 9affd6c. Consider uploading reports for the commit 9affd6c to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
+ Coverage   91.73%   92.54%   +0.80%     
==========================================
  Files           7        7              
  Lines         472      523      +51     
==========================================
+ Hits          433      484      +51     
  Misses         39       39              
Impacted Files Coverage Δ
depfinder/stdliblist.py 78.57% <66.66%> (ø)
depfinder/cli.py 94.89% <91.66%> (-0.25%) ⬇️
depfinder/inspection.py 90.13% <92.85%> (+1.40%) ⬆️
depfinder/utils.py 88.13% <92.85%> (+5.63%) ⬆️
depfinder/reports.py 96.93% <95.00%> (+0.38%) ⬆️
depfinder/main.py 95.74% <97.61%> (+0.34%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants