ui: remove timeScale update from statement details link from insight …

…details Fixes cockroachdb#97952. This commit removes the setTimeScale call from the StatementDetailsLink function. Navigating to the Statement Details page from the Insights Details page will no longer set the global time scale to 0 minutes. Epic: none Release note: None
ericharmeling · Mar 7, 2023 · 4b95c34 · 4b95c34
1 parent 709d765
commit 4b95c34
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 15 deletions.
diff --git a/pkg/ui/workspaces/cluster-ui/src/insights/workloadInsightDetails/insightDetailsTables.tsx b/pkg/ui/workspaces/cluster-ui/src/insights/workloadInsightDetails/insightDetailsTables.tsx
@@ -61,7 +61,7 @@ export function makeInsightDetailsColumns(
       ),
       cell: (item: ContentionEvent) =>
         item.stmtInsightEvent
-          ? StatementDetailsLink(item.stmtInsightEvent, setTimeScale)
+          ? StatementDetailsLink(item.stmtInsightEvent)
           : item.waitingStmtFingerprintID,
       sort: (item: ContentionEvent) => item.waitingStmtFingerprintID,
     },

diff --git a/...ces/cluster-ui/src/insights/workloadInsightDetails/statementInsightDetailsOverviewTab.tsx b/...ces/cluster-ui/src/insights/workloadInsightDetails/statementInsightDetailsOverviewTab.tsx
@@ -171,7 +171,7 @@ export const StatementInsightDetailsOverviewTab: React.FC<
             />
             <SummaryCardItem
               label="Statement Fingerprint ID"
-              value={StatementDetailsLink(insightDetails, setTimeScale)}
+              value={StatementDetailsLink(insightDetails)}
             />
           </SummaryCard>
         </Col>

diff --git a/...ces/cluster-ui/src/insights/workloadInsights/statementInsights/statementInsightsTable.tsx b/...ces/cluster-ui/src/insights/workloadInsights/statementInsights/statementInsightsTable.tsx
@@ -64,8 +64,7 @@ export function makeStatementInsightsColumns(
     {
       name: "statementFingerprintID",
       title: insightsTableTitles.fingerprintID(execType),
-      cell: (item: StmtInsightEvent) =>
-        StatementDetailsLink(item, setTimeScale),
+      cell: (item: StmtInsightEvent) => StatementDetailsLink(item),
       sort: (item: StmtInsightEvent) => item.statementFingerprintID,
       showByDefault: true,
     },

diff --git a/pkg/ui/workspaces/cluster-ui/src/insights/workloadInsights/util/detailsLinks.tsx b/pkg/ui/workspaces/cluster-ui/src/insights/workloadInsights/util/detailsLinks.tsx
@@ -41,7 +41,6 @@ export function TransactionDetailsLink(
 
 export function StatementDetailsLink(
   insightDetails: StmtInsightEvent,
-  setTimeScale: (tw: TimeScale) => void,
 ): React.ReactElement {
   const linkProps = {
     statementFingerprintID: HexStringToInt64String(
@@ -50,18 +49,9 @@ export function StatementDetailsLink(
     appNames: [insightDetails.application],
     implicitTxn: insightDetails.implicitTxn,
   };
-  const timeScale: TimeScale = {
-    windowSize: moment.duration(insightDetails.elapsedTimeMillis),
-    fixedWindowEnd: insightDetails.endTime,
-    sampleSize: moment.duration(1, "hour"),
-    key: "Custom",
-  };
 
   return (
-    <Link
-      to={StatementLinkTarget(linkProps)}
-      onClick={() => setTimeScale(timeScale)}
-    >
+    <Link to={StatementLinkTarget(linkProps)}>
       <div>{String(insightDetails.statementFingerprintID)}</div>
     </Link>
   );