Skip to content

Commit

Permalink
WIP: chore!: remove GPUCommandEncoder.writeTimestamp API
Browse files Browse the repository at this point in the history
See [`gpuweb/gpuweb`gfx-rs#4370](gpuweb/gpuweb#4370).
  • Loading branch information
ErichDonGubler committed Jan 30, 2024
1 parent e2e9ef5 commit 83fa0e3
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 32 deletions.
24 changes: 0 additions & 24 deletions wgpu/src/backend/webgpu.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2492,19 +2492,6 @@ impl crate::context::Context for ContextWebGpu {
// encoder.pop_debug_group();
}

fn command_encoder_write_timestamp(
&self,
_encoder: &Self::CommandEncoderId,
encoder_data: &Self::CommandEncoderData,
_query_set: &Self::QuerySetId,
query_set_data: &Self::QuerySetData,
query_index: u32,
) {
encoder_data
.0
.write_timestamp(&query_set_data.0, query_index);
}

fn command_encoder_resolve_query_set(
&self,
_encoder: &Self::CommandEncoderId,
Expand Down Expand Up @@ -2805,17 +2792,6 @@ impl crate::context::Context for ContextWebGpu {
// self.0.pop_debug_group();
}

fn compute_pass_write_timestamp(
&self,
_pass: &mut Self::ComputePassId,
_pass_data: &mut Self::ComputePassData,
_query_set: &Self::QuerySetId,
_query_set_data: &Self::QuerySetData,
_query_index: u32,
) {
panic!("TIMESTAMP_QUERY_INSIDE_PASSES feature must be enabled to call write_timestamp in a compute pass")
}

fn compute_pass_begin_pipeline_statistics_query(
&self,
_pass: &mut Self::ComputePassId,
Expand Down
8 changes: 0 additions & 8 deletions wgpu/src/context.rs
Original file line number Diff line number Diff line change
Expand Up @@ -504,14 +504,6 @@ pub trait Context: Debug + WasmNotSendSync + Sized {
encoder_data: &Self::CommandEncoderData,
);

fn command_encoder_write_timestamp(
&self,
encoder: &Self::CommandEncoderId,
encoder_data: &Self::CommandEncoderData,
query_set: &Self::QuerySetId,
query_set_data: &Self::QuerySetData,
query_index: u32,
);
#[allow(clippy::too_many_arguments)]
fn command_encoder_resolve_query_set(
&self,
Expand Down

0 comments on commit 83fa0e3

Please sign in to comment.