-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply P0547R2 #456
Apply P0547R2 #456
Conversation
Updated to fix merge conflicts. |
concepts.tex
Outdated
\end{itemdecl} | ||
|
||
\begin{itemdescr} | ||
\pnum | ||
<<<<<<< 142646fd53fd433ab929d28f9799c45bbaa4bb57 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great failure. Maybe you should save the changes before committing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
8ca7492
to
0b2ceb4
Compare
...and again. |
|
||
\pnum | ||
There need not be any subsumption relationship between \tcode{Assignable<T, U>} | ||
and \tcode{is_lvalue_reference<T>::value}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to wrap is_lvalue_reference<T>::value
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I plan to handle poor line wrapping in a separate pass after incorporating all of the PRs. I've added a note to #455 to be sure to check these two occurrences specifically.
\item The expression \tcode{\&t} is non-modifying. | ||
\end{itemize} | ||
There need not be any subsumption relationship between \tcode{Destructible<T>} | ||
and \tcode{is_nothrow_destructible<T>::value}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is_nothrow_destructible<T>::value
needs to be wrapped.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto later.
concepts.tex
Outdated
|
||
\item If \tcode{T} is not \tcode{const}, \tcode{rv}'s resulting state is valid | ||
but unspecified~(\cxxref{lib.types.movedfrom}). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You forgot "; otherwise, it is unchanged."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix pending.
Content fix applied (saving pure presentation fixes for later). |
Fixes #70, #229, #300, #301, #310, #313, #339, #381, #382, #387, #399.