Address comments from ARMReview

ericshape · Dec 9, 2022 · cdeda23 · cdeda23
1 parent 7f20066
commit cdeda23
Showing 1 changed file with 33 additions and 15 deletions.
diff --git a/...tion/reservations/resource-manager/Microsoft.Capacity/stable/2022-11-01/reservations.json b/...tion/reservations/resource-manager/Microsoft.Capacity/stable/2022-11-01/reservations.json
@@ -165,6 +165,9 @@
             "$ref": "./examples/GetAppliedReservations.json"
           }
         },
+        "x-ms-pageable": {
+          "nextLinkName": "nextLink"
+        },
         "parameters": [
           {
             "$ref": "#/parameters/ApiVersionParameter"
@@ -1378,7 +1381,9 @@
           "items": {
             "$ref": "#/definitions/ReservationToReturn"
           },
-          "x-ms-identifiers": []
+          "x-ms-identifiers": [
+            "reservationId"
+          ]
         }
       }
     },
@@ -1648,7 +1653,6 @@
           "description": "Name of the reservation"
         },
         "properties": {
-          "x-ms-client-flatten": true,
           "$ref": "#/definitions/ReservationOrderProperties"
         },
         "type": {
@@ -1738,6 +1742,7 @@
     },
     "ReservationOrderProperties": {
       "type": "object",
+      "x-ms-client-flatten": true,
       "properties": {
         "displayName": {
           "type": "string",
@@ -1969,7 +1974,11 @@
           "type": "string"
         },
         "valid": {
-          "type": "boolean"
+          "type": "string",
+          "enum": [
+            "true",
+            "false"
+          ]
         }
       }
     },
@@ -2247,7 +2256,9 @@
           "items": {
             "$ref": "#/definitions/ReservationToExchange"
           },
-          "x-ms-identifiers": []
+          "x-ms-identifiers": [
+            "reservationId"
+          ]
         },
         "policyResult": {
           "$ref": "#/definitions/ExchangePolicyErrors"
@@ -2277,23 +2288,29 @@
           "items": {
             "$ref": "#/definitions/ReservationToPurchaseExchange"
           },
-          "x-ms-identifiers": []
+          "x-ms-identifiers": [
+            "reservationId"
+          ]
         },
         "savingsPlansToPurchase": {
           "type": "array",
           "description": "Details of the savings plans being purchased",
           "items": {
             "$ref": "#/definitions/SavingsPlanToPurchaseExchange"
           },
-          "x-ms-identifiers": []
+          "x-ms-identifiers": [
+            "savingsPlanId"
+          ]
         },
         "reservationsToExchange": {
           "type": "array",
           "description": "Details of the reservations being returned",
           "items": {
             "$ref": "#/definitions/ReservationToReturnForExchange"
           },
-          "x-ms-identifiers": []
+          "x-ms-identifiers": [
+            "reservationId"
+          ]
         },
         "policyResult": {
           "$ref": "#/definitions/ExchangePolicyErrors"
@@ -2696,6 +2713,7 @@
     },
     "PurchaseRequestProperties": {
       "type": "object",
+      "x-ms-client-flatten": true,
       "properties": {
         "reservedResourceType": {
           "$ref": "#/definitions/ReservedResourceType"
@@ -2747,6 +2765,7 @@
     },
     "SavingsPlanPurchaseRequestProperties": {
       "type": "object",
+      "x-ms-client-flatten": true,
       "properties": {
         "displayName": {
           "type": "string",
@@ -2851,6 +2870,7 @@
     },
     "PatchProperties": {
       "type": "object",
+      "x-ms-client-flatten": true,
       "properties": {
         "appliedScopeType": {
           "$ref": "#/definitions/AppliedScopeType"
@@ -2888,6 +2908,7 @@
     },
     "SplitProperties": {
       "type": "object",
+      "x-ms-client-flatten": true,
       "properties": {
         "quantities": {
           "type": "array",
@@ -2907,6 +2928,7 @@
     },
     "MergeProperties": {
       "type": "object",
+      "x-ms-client-flatten": true,
       "properties": {
         "sources": {
           "type": "array",
@@ -2921,7 +2943,6 @@
       "type": "object",
       "properties": {
         "properties": {
-          "x-ms-client-flatten": true,
           "$ref": "#/definitions/MergeProperties"
         }
       }
@@ -2937,7 +2958,6 @@
           "description": "The Azure Region where the reserved resource lives."
         },
         "properties": {
-          "x-ms-client-flatten": true,
           "$ref": "#/definitions/PurchaseRequestProperties"
         }
       }
@@ -2949,7 +2969,6 @@
           "$ref": "#/definitions/SkuName"
         },
         "properties": {
-          "x-ms-client-flatten": true,
           "$ref": "#/definitions/SavingsPlanPurchaseRequestProperties"
         }
       }
@@ -2958,7 +2977,6 @@
       "type": "object",
       "properties": {
         "properties": {
-          "x-ms-client-flatten": true,
           "$ref": "#/definitions/PatchProperties"
         }
       }
@@ -2967,7 +2985,6 @@
       "type": "object",
       "properties": {
         "properties": {
-          "x-ms-client-flatten": true,
           "$ref": "#/definitions/SplitProperties"
         }
       }
@@ -3041,13 +3058,13 @@
           "readOnly": true
         },
         "properties": {
-          "x-ms-client-flatten": true,
           "$ref": "#/definitions/AppliedReservationsProperties"
         }
       }
     },
     "AppliedReservationsProperties": {
       "type": "object",
+      "x-ms-client-flatten": true,
       "properties": {
         "reservationOrderIds": {
           "$ref": "#/definitions/AppliedReservationList"
@@ -3062,7 +3079,8 @@
           "items": {
             "type": "string",
             "description": "Reservation resource Id. \"/providers/Microsoft.Capacity/reservationOrders/{reservationOrderId}\""
-          }
+          },
+          "x-ms-identifiers": []
         },
         "nextLink": {
           "type": "string",
@@ -3247,7 +3265,7 @@
     },
     "BillingScopeId": {
       "type": "string",
-      "description": "Subscription that will be charged for purchasing Reservation or Savings Plan"
+      "description": "Subscription that will be charged for purchasing reservation or savings plan"
     },
     "Price": {
       "type": "object",