-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sqlite3_serialize and sqlite3_deserialize #547
Conversation
I'm having a hard time getting the build to work, which is stopping me from adding tests:
I already have MAUI and Xamarin workloads installed for VS 2022. Not sure what I'm missing. |
You may want to compare what you have installed against what is installed by the GitHub action in this repo. We're probably still building with stuff a bit older than VS 2022 for classic Xamarin. |
@Trinitek target issue for To install API 28, open visual studio without opening a project. |
Thanks @farzonl. I've made some progress on this but I'm now blocked on the iOS project, similar to the issue with Android. I'm actually wondering if I truly need to have VS 2019 instead of 2022? I wondered if that was the README being out of date, but maybe not. I'll give that a try next.
I am running this from the VS 2022 Developer prompt as mentioned by the README. Here are my workloads:
|
Yeah that was it. 🤦 VS 2019 with the dotnet 3.1 SDK. |
@ericsink This is ready for a re-review whenever you have a chance. |
Hmmm. I wonder why Github isn't offering me a chance to run the build/test action on this PR. |
Never mind previous comment. The tests do pass. I'm still reviewing the diffs. |
Nice work on this PR. Thanks, and I apologize for all the delays. |
Closes #530.
This also exposes
sqlite3_malloc
,sqlite3_malloc64
, andsqlite3_free
because these are necessary for consumers to fully utilize the serialization functions.For
sqlite3_deserialize
I decided to takeIntPtr
andlong
size parameters instead of aReadOnlySpan<byte>
as I originally wanted to do because spans only have anint
Length property, which would cap the database size at 2 GB. I did not want to impose that sort of artificial limitation.