various cleanup #104
Merged
various cleanup #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
flepied
commented
Dec 15, 2017
flepied
commented
- fix README to show correct import statements
- fixed flake8 reports
- removed get_markets and get_market_history that seems not available anymore in V2_0
- use /key/orders/getorderhistory to get order history by market in V2_0
- tests: tweak IS_CI_ENV to only rely on secrets.json being present
- fix README to show correct import statements - fixed flake8 reports - removed get_markets and get_market_history that seems not available anymore in V2_0 - use /key/orders/getorderhistory to get order history by market in V2_0 - tests: tweak IS_CI_ENV to only rely on secrets.json being present
ericsomdahl
reviewed
Dec 15, 2017
| @@ -167,7 +165,7 @@ def get_markets(self): | |||
| at Bittrex along with other meta data. | |||
|
|
|||
| 1.1 Endpoint: /public/getmarkets | |||
| 2.0 Endpoint: /pub/Markets/GetMarkets | |||
| 2.0 NO Equivalent | |||
There was a problem hiding this comment.
I am not so sure that these endpoints are permanently gone... but they are definitely broken now. If they come back we can re-enable this functionality.
ericsomdahl
added a commit
that referenced
this pull request
Dec 15, 2017
PR #104 removes two broken 2.0 API endpoints
skyl
reviewed
Dec 15, 2017
| @@ -19,7 +19,7 @@ Installation | |||
| Example Usage for Bittrex API | |||
|
|
|||
| ```python | |||
| from bittrex import Bittrex | |||
There was a problem hiding this comment.
Does from bittrex import Bittrex not work? I thought the import in the __init__.py would make it work. Seems like a nicer way to import versus from bittrex.bittrex import Bittrex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.