Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caplin: Fixed not calling FCU due to faulty blob handling #9779

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

Giulio2002
Copy link
Contributor

@Giulio2002 Giulio2002 commented Mar 21, 2024

This is kind of a low priority issue.

We need blobs corresponding to each blocks, but before we were not checking if we received all of them, now we ask until the request returns the desired amount.

@Giulio2002 Giulio2002 enabled auto-merge (squash) March 22, 2024 00:32
Copy link
Contributor

@bayram98 bayram98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@Giulio2002 Giulio2002 merged commit b682aa1 into devel Mar 22, 2024
6 checks passed
@Giulio2002 Giulio2002 deleted the fix-gnosis-fall-sync branch March 22, 2024 03:42
@yperbasis yperbasis added the dencun The Deneb/Cancun protocol upgrade label Mar 22, 2024
yperbasis pushed a commit that referenced this pull request Mar 27, 2024
This is kind of a low priority issue.

We need blobs corresponding to each blocks, but before we were not
checking if we received all of them, now we ask until the request
returns the desired amount.
yperbasis added a commit that referenced this pull request Mar 27, 2024
Cherry pick PR #9779 into the release

Co-authored-by: Giulio rebuffo <giulio.rebuffo@gmail.com>
Kakkarrot pushed a commit to covalenthq/erigon that referenced this pull request Apr 17, 2024
…#9818)

Cherry pick PR erigontech#9779 into the release

Co-authored-by: Giulio rebuffo <giulio.rebuffo@gmail.com>
@ghost ghost mentioned this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
caplin dencun The Deneb/Cancun protocol upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants