feat: Add bool return trype to process event (#172)

erikzenker · Nov 27, 2021 · fbea52e · fbea52e
1 parent fe5461d
commit fbea52e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/include/hsm/details/sm.h b/include/hsm/details/sm.h
@@ -77,7 +77,7 @@ template <class RootState, class... OptionalParameters> class sm {
         update_current_regions();
     }
 
-    template <class Event> auto process_event(Event&& event)
+    template <class Event> auto process_event(Event&& event) -> bool
     {
         static_assert(
             bh::contains(
@@ -87,10 +87,11 @@ template <class RootState, class... OptionalParameters> class sm {
 
         if (!process_event_internal(event)) {
             call_unexpected_event_handler(event);
-            return;
+            return false;
         }
 
         process_deferred_events();
+        return true;
     }
 
     template <class State> auto is(State state) -> bool

diff --git a/test/integration/unexpected_event_handler.cpp b/test/integration/unexpected_event_handler.cpp
@@ -63,18 +63,18 @@ class UnexpectedEventHandler : public Test {
 TEST_F(UnexpectedEventHandler, should_call_unexpected_event_handler)
 {
     auto event = e2 {};
-    sm.process_event(event);
+    ASSERT_FALSE(sm.process_event(event));
 
     ASSERT_TRUE(event.called);
 }
 
 TEST_F(UnexpectedEventHandler, should_not_call_unexpected_event_handler_when_guard_fails)
 {
 
-    sm.process_event(e3 {});
+    ASSERT_TRUE(sm.process_event(e3 {}));
 
     auto event = e2 {};
-    sm.process_event(event);
+    ASSERT_TRUE(sm.process_event(event));
 
     ASSERT_FALSE(event.called);
 }