Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in asn1 flag name? #8779

Closed
vances opened this issue Sep 4, 2024 · 1 comment · Fixed by #8781
Closed

Typo in asn1 flag name? #8779

vances opened this issue Sep 4, 2024 · 1 comment · Fixed by #8781
Assignees
@bjorng
Labels
bug Issue is reported as a bug team:VM Assigned to OTP team VM

Comments

@vances
Copy link
Contributor

vances commented Sep 4, 2024

Describe the bug
Typo in asn1 flag name?

To Reproduce

Expected behavior

Affected versions
HEAD

Additional context
On line 1385 of /lib/asn1/src/asn1ct.erl it looks like a typo of the flag name. It is undec_rec which doesn't appear anywhere else in the repo however there is an asn1ct flag named undec_rest.
@vances vances added the bug Issue is reported as a bug label Sep 4, 2024
@bjorng bjorng added the team:VM Assigned to OTP team VM label Sep 5, 2024
@bjorng bjorng self-assigned this Sep 5, 2024
@bjorng bjorng mentioned this issue Sep 5, 2024
Merged
@bjorng bjorng linked a pull request Sep 5, 2024 that will close this issue
asn1: Don't pass on the undec_rest option to the Erlang compiler #8781
Merged
@bjorng
Copy link
Contributor

bjorng commented Sep 5, 2024

Thanks! Fixed in the linked pull request.

bjorng added a commit that referenced this issue Sep 6, 2024
@bjorng
Merge pull request #8781 from bjorng/bjorn/asn1/fix-typo/GH-8779/OTP-…
3676f2c 
…19218

asn1: Don't pass on the undec_rest option to the Erlang compiler
@bjorng bjorng closed this as completed in 54161df Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bjorng bjorng

Labels
bug Issue is reported as a bug team:VM Assigned to OTP team VM
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

asn1: Don't pass on the undec_rest option to the Erlang compiler bjorng/otp
2 participants
@bjorng @vances