crypto: Fix AES and Blowfish names for OpenSSL 3.0 #6196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change AES in 128 bit CFB mode and Blowfish in CFB/OFB modes are always reported as unsupported when linked with OpenSSL 3.0.
|
|
CT Test Results 2 files 14 suites 5m 9s ⏱️ Results for commit a822fe7. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
HansN
added
team:PS
|
Thanks for the PR! |
HansN
removed
testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #6146. It turned out that Blowfish in CFB/OFB modes is also not detected as supported.
Tested with OpenSSL 3.0.5. Corresponding groups for AES and Blowfish in crypto_SUITE are not skipped and pass.