Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lost exception from map update #6965

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Fix lost exception from map update #6965

merged 1 commit into from
Mar 10, 2023

Conversation

bjorng
Copy link
Contributor

@bjorng bjorng commented Mar 3, 2023

Fix an unsafe optimization that would remove a map update operation that is supposed fail. For example:

foo() ->
    #{}#{key := value},
    ok.

Instead of raising an exception, foo/0 would return ok.

Closes #6960

@bjorng
Fix lost exception from map update
a5cb4f6 
Fix an unsafe optimization that would remove a map update operation
that is supposed fail. For example:

    foo() ->
        #{}#{key := value},
        ok.

Instead of raising an exception, `foo/0` would return `ok`.

Closes erlang#6960
@bjorng bjorng added team:VM Assigned to OTP team VM fix labels Mar 3, 2023
@bjorng bjorng requested a review from jhogberg March 3, 2023 03:44
@bjorng bjorng self-assigned this Mar 3, 2023
@bjorng bjorng linked an issue Mar 3, 2023 that may be closed by this pull request
erlc folds away an unused map update that should throw an exception #6960
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023 •
edited
Loading

CT Test Results

       2 files     253 suites   8m 48s ⏱️
   730 tests    728 ✔️ 2 💤 0 ❌
3 979 runs  3 977 ✔️ 2 💤 0 ❌

Results for commit a5cb4f6.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@bjorng bjorng merged commit 5063a62 into erlang:maint Mar 10, 2023
@bjorng bjorng deleted the bjorn/compiler/fix-lost-map-exception/GH-6960/OTP-18497 branch June 9, 2023 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhogberg jhogberg Awaiting requested review from jhogberg

Assignees

@bjorng bjorng

Labels
fix team:VM Assigned to OTP team VM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

erlc folds away an unused map update that should throw an exception
1 participant
@bjorng