crypto: Warning if FIPS supported but application 'crypto' not loaded #8590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CT Test Results 2 files 14 suites 6m 8s ⏱️ Results for commit 04ce711. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
sverker
force-pushed
the
sverker/crypto/fips-warning-app-not-loaded
branch
from
0497685
to
dd35807
Compare
in which case FIPS is disabled by default.
sverker
force-pushed
the
sverker/crypto/fips-warning-app-not-loaded
branch
from
dd35807
to
04ce711
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8582.
To enable FIPS mode, crypto application config parameter
fips_modemust betrue.However, the application must first be loaded for the config to be accessible when module crypto is invoked.
If application crypto is not loaded, module crypto will use default
fips_modeasfalsewhich may come as a surprise if erl was started with command line-crypto fips_mode true.Issue this warning if the underlying OpenSSL lib supports FIPS but the crypto application has not been loaded: