Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support application/jwk-set+json content-type #352

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

caioaao
Copy link
Contributor

@caioaao caioaao commented May 29, 2024

Some providers will return this content-type, which is just a JSON content-type with stronger guarantees, so it's safe to just treat it as regular JSON

https://webconcepts.info/concepts/media-type/application/jwk-set+json

Some providers will return this content-type, which is just a JSON
content-type with stronger guarantees, so it's safe to just treat it as
regular JSON

https://webconcepts.info/concepts/media-type/application/jwk-set+json
@maennchen
Copy link
Member

@maennchen maennchen enabled auto-merge (squash) May 29, 2024 16:58
@caioaao
Copy link
Contributor Author

caioaao commented May 29, 2024

@maennchen seems like there's some instability in github's network, that's why the tests failed. It seems like I can't re-run them, though

@maennchen maennchen merged commit ad35792 into erlef:main May 29, 2024
23 of 25 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 177

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 92.188%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/oidcc_http_util.erl 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
src/oidcc_provider_configuration_worker.erl 1 96.3%
Totals Coverage Status
Change from base Build 171: -0.2%
Covered Lines: 1062
Relevant Lines: 1152

💛 - Coveralls

@maennchen
Copy link
Member

Thanks @caioaao ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants