Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI (don't use 26.2.5 on Windows; be strict when comparing versions) #299

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

paulo-ferraz-oliveira
Copy link
Collaborator

@paulo-ferraz-oliveira paulo-ferraz-oliveira commented Jul 13, 2024

Description

  1. remove Windows 26.2.5 from tests: (resolved) 26.2.5.2 is not installing properly, but the action's CI shouldn't be affected for this.

  2. properly simulate version-type strict when required to not have e.g. 27.0 identify as (recently released) 27.0.1 when that's unexpected.

Motivation

The motivation for this change was the report in #298, which made me look into why we had issues with version resolution. (issue is not in code, but tests' expectations)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these pertain to properly testing over strict, otherwise (as is the case) Erlang/OTP releases 27.0.1 and our tests break because we're expecting 27 to resolve to 27.0.

26.2.5.2 (recently released) has an issue and exits with non-0
@paulo-ferraz-oliveira paulo-ferraz-oliveira changed the title Fix/tests Fix CI Jul 13, 2024
@paulo-ferraz-oliveira paulo-ferraz-oliveira changed the title Fix CI Fix CI (don't use 26.2.5 on Windows; be strict when comparing versions) Jul 13, 2024
@starbelly starbelly merged commit ee8d6d1 into main Jul 17, 2024
63 checks passed
@starbelly starbelly deleted the fix/tests branch July 17, 2024 00:52
@paulo-ferraz-oliveira
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants