Minor revisions #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,7 +1,7 @@ | |||
| PEP: 755 | |||
| Title: Status quo of the CPython 3.12 build system | |||
| Author: Erlend Egeberg Aasland <erlend@python.org>, | |||
| Zachary Ware <zachary.ware@gmail.com> | |||
| Zachary Ware <zach@python.org> | |||
There was a problem hiding this comment.
BTW, you'll need to fix your email in your previous PEPs first. I had to do the same (see python#3463)
| For core developers, a common use cases are _reconfigure_ and _rebuild_; | ||
| this was reflected in the poll responses: | ||
| we want fast and correct incremental builds. | ||
| For core developers, a common use case is _reconfigure_ and _rebuild_: |
There was a problem hiding this comment.
How about this?
Suggested change
| For core developers, a common use case is _reconfigure_ and _rebuild_: | |
| For core developers, common use cases are _reconfigure_ and _rebuild_: |
erlend-aasland
approved these changes
Oct 9, 2023
erlend-aasland
merged commit ed52a72
into
erlend-aasland:build-system/part1
2 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I finally had a chance to look through and had a few relatively minor suggestions.
I also want to go through our poll results again to refresh my memory. I feel like there's more in them that we could stand to add here.
📚 Documentation preview 📚: https://pep-previews--4.org.readthedocs.build/