ecrn_agent: fix monthly and weekly cron jobs parsing #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good job！ |
|
@Ledest are you still interested in merging this? |
|
Yes, but I requested 3 first commits only, not 21 commits. |
|
ok. Put out a new PR?
…On Mon, May 13, 2019 at 8:28 AM Led ***@***.***> wrote:
@Ledest <https://github.com/Ledest> are you still interested in merging
this?
Yes, but I requested 3 first commits only, not 21 commits.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#45?email_source=notifications&email_token=AAABFXFSF3CZEB5VRZDOX5TPVGCLRA5CNFSM4DUBCBI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVIVUGA#issuecomment-491870744>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAABFXCJI4E3N7COXWO7AJTPVGCLRANCNFSM4DUBCBIQ>
.
|
|
@Ledest, could you squash your commits, and fix conflicts? |
|
It is a pretty stale PR. Could you review and see if it's still necessary given the existing changes in the master branch since the time this PR was created? |
|
@Ledest, could you resolve conflicts, please, and split this into two PRs - one fixing the actual issue in the subject along with test cases, and one for other minor improvements? |
|
@Ledest, could you rebase on master? This PR has very many conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.