Introduce suite name and some bugs fixing #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kristfoograb
commented
Jul 2, 2020
•
kristfoograb
commented
- Introduce suite name - raised by Group name is missing in full test name / suites info not populated #8
- Remove exporting of duplicate test - raised by Incorrect test count in release 1.8.0 #22
- Fix duration not shown when time taken for test run is less than 1 second
…n not shown when time taken for test run is less than 1 second
kristfoograb
commented
Jul 2, 2020
| @@ -80,7 +80,8 @@ public TestResult format(final ExportMeta meta, final JsonNode node) { | |||
| if (Objects.nonNull(result.getStart())) { | |||
| if (node.has(DURATION)) { | |||
| final Double durationText = node.get(DURATION).get(VALUE).asDouble(); | |||
| result.setStop(result.getStart() + TimeUnit.SECONDS.toMillis(durationText.longValue())); | |||
There was a problem hiding this comment.
Fix test run that take lesser than 1 second will show as 0 second in allure report.
kristfoograb
commented
Jul 2, 2020
| @@ -139,6 +144,17 @@ private void runUnsafe() throws Exception { | |||
| } | |||
| } | |||
|
|
|||
| private ExportMeta getTestMeta(ExportMeta meta, JsonNode testableSummary) { | |||
There was a problem hiding this comment.
Ensure suite name is captured and exported as part of JSON so that allure report when generate, the test will be categorised by suite
kristfoograb
commented
Jul 2, 2020
| } | ||
| if (test.has(TYPE) && test.get(TYPE).get(NAME).textValue().equals("ActionTestMetadata")) { |
There was a problem hiding this comment.
I believe the introduction of unit test support has resulted in duplicate tests being exported in JSON. When allure report is generated, the number of tests shown are double.
eroshenkoam
approved these changes
Jul 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.