Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove single quotes from vale_flags example #83

Merged
merged 1 commit into from
Oct 22, 2022

Conversation

lithammer
Copy link
Contributor

@lithammer lithammer commented Oct 21, 2022

Because of how this is executed (i.e. no shell), the quotes will actually end up being part of the glob pattern resulting in no matches 99.9% of the time.

Related issue #75

Because of how this is executed, the quotes will actually end up being
part of the glob pattern resulting in no matches 99.9% of the time.
@jdkato jdkato merged commit e9cd17e into errata-ai:reviewdog Oct 22, 2022
@lithammer lithammer deleted the fix-vale_flags-glob-example branch October 24, 2022 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants